Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay mechanism for QGB relayer #344

Merged
merged 14 commits into from
Apr 25, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Apr 21, 2022

This change will make the relayer start from the QGB contract last state and relay from there.

Closes: #338 and #345

@rach-id rach-id marked this pull request as draft April 21, 2022 18:28
@rach-id rach-id self-assigned this Apr 21, 2022
@rach-id rach-id added the C: QGB label Apr 21, 2022
@rach-id rach-id changed the title Simple replay mechanism for QGB replayer Simple replay mechanism for QGB relayer Apr 22, 2022
@rach-id rach-id changed the title Simple replay mechanism for QGB relayer Replay mechanism for QGB relayer Apr 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (qgb-integration@95f5208). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             qgb-integration     #344   +/-   ##
==================================================
  Coverage                   ?   13.36%           
==================================================
  Files                      ?       54           
  Lines                      ?     9724           
  Branches                   ?        0           
==================================================
  Hits                       ?     1300           
  Misses                     ?     8333           
  Partials                   ?       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f5208...9efe1b5. Read the comment docs.

@rach-id
Copy link
Member Author

rach-id commented Apr 22, 2022

Can be merged after: #342

@rach-id rach-id marked this pull request as ready for review April 23, 2022 18:47
go.mod Outdated Show resolved Hide resolved
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. I have a question or two, but let's sync on what we want to do next sometime soon. Pre-approving until then

Comment on lines +45 to +52
// TODO make gas limit configurable
builder.SetGasLimit(9999999999999)
// TODO: update this api
// via https://github.com/celestiaorg/celestia-app/pull/187/commits/37f96d9af30011736a3e6048bbb35bad6f5b795c
tx, err := bc.signer.BuildSignedTx(builder, msg)
if err != nil {
return "", err
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we planning on handling this before we merge this, in a different refactor, or do we want to create an issue?

as suggested here, we might be able to using something similar to

for _, option := range options {
builder = option(builder)
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be addressed in a separate PR as this PR only focuses on replaying missing attestations to the QGB contract

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan-forbes Can you please create an issue for this as I am not sure how to use these options.
Thanks a lot

x/qgb/orchestrator/broadcaster.go Show resolved Hide resolved
@rach-id rach-id merged commit 2d3c072 into celestiaorg:qgb-integration Apr 25, 2022
@rach-id rach-id deleted the relayer_replay branch April 25, 2022 12:18
rach-id added a commit to rach-id/celestia-app that referenced this pull request May 9, 2022
* adds valset request by nonce

* add querier, broadcaster and updates orchestrator to use them

* partially fix the tests for the new design

* update the deployer for the new design

* update orchestrator to new design

* Adds querier and evm client update

* update relayer to new design

* fix query.proto

* update deploy_command to use new Querier

* formatting

* formatting

* go.sum

* revert go.mod change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

QGB replaying relaying data commitments QGB replaying relaying valsets
4 participants