adds evm_client wait for transaction confirmation to QGB #354
Conversation
rach-id
changed the title
| ec.logger.Info("ValSetUpdate", tx.Hash().String()) | ||
|
|
||
| // TODO put this in a separate function and listen for new EVM blocks instead of just sleeping | ||
| for i := 0; i < 60; i++ { |
There was a problem hiding this comment.
It was 6 at the beginning to wait for a minute. However, I am testing against rinkeby/ropsten, and they take a lot of time to include transactions in blocks. So, I changed it to 10 minutes of wait time.
In the future, when we have the worker pool design, we will change this by listening to new blocks and waiting for a number of confirmations before moving to the next attestation
There was a problem hiding this comment.
This is a QGB contract in action:
https://ropsten.etherscan.io/address/0x820a20eb3c8f7789557595874b89dd71fea11a0e
I am generating a new valset every 15 Celestia blocks.
Don't mind the failing transactions, as those are duplicates (will be fixed when we implement the new design)
PS: We still don't use the latest nonce => height change, and we're deploying an older version
| // TODO put this in a separate function and listen for new EVM blocks instead of just sleeping | ||
| for i := 0; i < 60; i++ { | ||
| ec.logger.Debug(fmt.Sprintf("waiting for valset %d to be confirmed: %s", nonce, tx.Hash().String())) | ||
| lastNonce, err := ec.StateLastValsetNonce(&bind.CallOpts{Context: ctx}) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if lastNonce == nonce { | ||
| ec.logger.Info(fmt.Sprintf("relayed valset %d: %s", nonce, tx.Hash().String())) | ||
| return nil | ||
| } | ||
| time.Sleep(10 * time.Second) | ||
| } |
There was a problem hiding this comment.
as stated in the todo, I like the idea of a separate evm client method that waits for a specific update or something similar
There was a problem hiding this comment.
let's write that down in an issue if we haven't already tho
There was a problem hiding this comment.
We can create a generic method that subscribes to new blocks and checks if a transaction hash is included or not.
Could be something like:
func (ec *EvmClient) waitForConfirmations(txHash string, numberOfConfirmations int) errorI wrote some snippets, but it would take much time debugging and making it work. Especially that subscribing to events requires using a web socket connection and that needs to be added to the config which itself needs to be updated to reflect the different commands.
Thus, I decided to leave it for later and do this instead.
There was a problem hiding this comment.
Let me know if we can merge.
Adds a simple waiting mechanism to wait for evm client transaction confirmation before sending the next transaction.
Closes #319