Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data commitment indexing key update #359

Merged

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Apr 27, 2022

Uses (end_block, begin_block, validator_address) to index data commitment confirms.
Closes: #353

@rach-id rach-id added the C: QGB label Apr 27, 2022
@rach-id rach-id self-assigned this Apr 27, 2022
@rach-id rach-id changed the base branch from master to qgb-integration April 27, 2022 16:53
@rach-id rach-id changed the title Data commitment keeper key update Data commitment indexing key update Apr 27, 2022
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, makes sense and follows what we discussed earlier in #353

@rach-id rach-id merged commit 8edfc38 into celestiaorg:qgb-integration Apr 27, 2022
@rach-id rach-id deleted the data_commitment_keeper_key_update branch April 27, 2022 17:19
rach-id added a commit to rach-id/celestia-app that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Data commitment roots for empty blocks returning same result
2 participants