Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds query data confirm by exact range #367

Merged
merged 1 commit into from
Apr 28, 2022
Merged

adds query data confirm by exact range #367

merged 1 commit into from
Apr 28, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Apr 28, 2022

Closes #366

@rach-id rach-id added the C: QGB label Apr 28, 2022
@rach-id rach-id self-assigned this Apr 28, 2022
@rach-id rach-id linked an issue Apr 28, 2022 that may be closed by this pull request
Add data commitment query by exact range to QGB #366
Closed
evan-forbes
evan-forbes approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely makes sense for now! 👍 LGTM

I created to #368 and #369 to remind us to take another look at the existing query functionality before we merge, as the functionality here might leave other queries unused.

@rach-id
Copy link
Member Author

rach-id commented Apr 28, 2022

Yes, 100% we will need to clean up the queries and also the keepers

@rach-id rach-id merged commit 4fe09dc into celestiaorg:qgb-integration Apr 28, 2022
@rach-id rach-id deleted the add_query_data_commitment_confirm_by_exact_range branch April 28, 2022 13:11
rach-id added a commit to rach-id/celestia-app that referenced this pull request May 9, 2022
@rach-id
adds query data confirm by exact range (celestiaorg#367)
1ec9eae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rach-id rach-id

Labels
None yet
Projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data commitment query by exact range to QGB
2 participants
@rach-id @evan-forbes