Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better structure QGB CLI flags #402

Merged
merged 1 commit into from
May 12, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented May 12, 2022

Closes #302

@rach-id rach-id requested a review from evan-forbes May 12, 2022 11:44
@rach-id rach-id self-assigned this May 12, 2022
@rach-id rach-id added the C: QGB label May 12, 2022
@@ -28,10 +28,10 @@ func init() {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan-forbes Parsing the flags in this file is a bit repetitive. However, I couldn't find a way to better structure them.
Please let me know if you have an idea on how to do it better.

@rach-id rach-id linked an issue May 12, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (qgb-integration@e14ed2e). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             qgb-integration     #402   +/-   ##
==================================================
  Coverage                   ?   11.80%           
==================================================
  Files                      ?       57           
  Lines                      ?    11162           
  Branches                   ?        0           
==================================================
  Hits                       ?     1318           
  Misses                     ?     9757           
  Partials                   ?       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14ed2e...6d2ae41. Read the comment docs.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. There are worse ways of organizing it, and while being brutally simple might not be able to serve our needs in the future, it certainly does now, along with sticking to the "pattern" that is already there!

@rach-id rach-id merged commit 57fc969 into celestiaorg:qgb-integration May 12, 2022
@rach-id rach-id deleted the elegant_qgb_cli_flags branch May 12, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update the CLI flags to correctly reflect the parameters needed for QGB
3 participants