Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes set latest data commitment nonce #481

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jun 10, 2022

A fix for a wrong check when setting the latest data commitment nonce

@rach-id rach-id added the C: QGB label Jun 10, 2022
@rach-id rach-id requested a review from evan-forbes June 10, 2022 20:54
@rach-id rach-id self-assigned this Jun 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #481 (8e0aeda) into qgb-integration (d537ff4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@                 Coverage Diff                 @@
##           qgb-integration     #481      +/-   ##
===================================================
- Coverage            10.33%   10.33%   -0.01%     
===================================================
  Files                   63       63              
  Lines                12871    12872       +1     
===================================================
  Hits                  1330     1330              
- Misses               11454    11455       +1     
  Partials                87       87              
Impacted Files Coverage Δ
x/qgb/keeper/keeper_data_commitment.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d537ff4...8e0aeda. Read the comment docs.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@rach-id rach-id merged commit b8ebb36 into celestiaorg:qgb-integration Jun 10, 2022
@rach-id rach-id deleted the fixes_set_latest_data_commitment_nonce branch June 10, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants