QGB E2e cosmetics #515
Merged
QGB E2e cosmetics #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## qgb-integration #515 +/- ##
================================================
Coverage 11.72% 11.72%
================================================
Files 65 65
Lines 10881 10881
================================================
Hits 1276 1276
Misses 9515 9515
Partials 90 90
Continue to review full report at Codecov.
|
evan-forbes
approved these changes
Jul 1, 2022
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
Jul 1, 2022
* cosmetics * better waiting for e2e orchestrator * use require instead of assert in some qgb e2e places * restore the confirm check * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go
rach-id
added a commit
that referenced
this pull request
Jul 10, 2022
* refactors orchestrator to be simpler * moves all queries to querier and uses a better orchestrator struct * adds retrier * moves enquiying logic to orchestrator * remove unnecessary new lines * adds a signaling channel to notify senders + better context cancelling * remove unnecessary added config fields * add new line * docs * docs * logs * logs * query valset confirm instead of dc confirm in qgb e2e wait for orch to start * QGB E2e cosmetics (#515) * cosmetics * better waiting for e2e orchestrator * use require instead of assert in some qgb e2e places * restore the confirm check * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * Update e2e/qgb/orchestrator_test.go * nits * update orchestrator tests * nits * cosmetics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cosmetic changes