QGB State machine error handling #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
changed the title
Codecov Report
@@ Coverage Diff @@
## qgb-integration #550 +/- ##
==================================================
- Coverage 9.68% 9.63% -0.06%
==================================================
Files 55 55
Lines 9379 9408 +29
==================================================
- Hits 908 906 -2
- Misses 8395 8423 +28
- Partials 76 79 +3
|
evan-forbes
approved these changes
Jul 21, 2022
Comment on lines
+49
to
+50
| // Too heavy, shouldn't mainly be used. | ||
| // Returns empty array if no element is found. |
There was a problem hiding this comment.
do you think we might be able to get rid of this in the future? We inherited this from the gravity bridge module's code iirc, and I think we might be able to design around it.
There was a problem hiding this comment.
yes, definitely, it has to do with indexing. If we start double indexing data using multiple keys, we can define iterators with more specific store ranges, and it would be way faster
There was a problem hiding this comment.
We should investigate however the storage cost if it is worth it compared to the gained performance
x/qgb/keeper/keeper_valset.go
Outdated
| if !found { | ||
| panic(sdkerrors.Wrap( | ||
| types.ErrNilAttestation, | ||
| fmt.Sprintf("stumbeled upon nil attestation for nonce %d", i), |
There was a problem hiding this comment.
Suggested change
| fmt.Sprintf("stumbeled upon nil attestation for nonce %d", i), | |
| fmt.Sprintf("found nil attestation for nonce %d", i), |
alternatively this
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error handling in state machine. It follows the following thinking:
LastAttestationNonce.(value, found, error)in other cases to know if element doesn't exist or some error occurred.(value, found, error)to know if an element doesn't exist or some error occurred.RequestResponse{ element: nil }, nilif the element doesn't exit and uses will need to do their checks.Closes: #437