Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds more configuration flags #556

Merged
merged 4 commits into from
Jul 24, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 24, 2022

Closes #307 and #506

@rach-id rach-id added the C: QGB label Jul 24, 2022
@rach-id rach-id requested a review from evan-forbes July 24, 2022 14:41
@rach-id rach-id self-assigned this Jul 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #556 (675e904) into qgb-integration (3d81287) will decrease coverage by 0.05%.
The diff coverage is 15.13%.

@@                Coverage Diff                 @@
##           qgb-integration    #556      +/-   ##
==================================================
- Coverage             9.68%   9.63%   -0.06%     
==================================================
  Files                   55      55              
  Lines                 9383    9408      +25     
==================================================
- Hits                   909     906       -3     
- Misses                8396    8423      +27     
- Partials                78      79       +1     
Impacted Files Coverage Δ
e2e/qgb/qgb_network.go 0.00% <0.00%> (ø)
x/qgb/abci.go 44.89% <0.00%> (+1.50%) ⬆️
x/qgb/genesis.go 0.00% <0.00%> (ø)
x/qgb/keeper/keeper_attestation.go 22.00% <0.00%> (-2.53%) ⬇️
x/qgb/keeper/keeper_data_commitment.go 0.00% <0.00%> (ø)
x/qgb/keeper/keeper_valset.go 27.11% <0.00%> (-4.89%) ⬇️
x/qgb/keeper/msg_server.go 0.00% <0.00%> (ø)
x/qgb/keeper/query_attestation.go 0.00% <0.00%> (ø)
x/qgb/keeper/query_general.go 0.00% <0.00%> (ø)
x/qgb/orchestrator/test/mock_querier.go 16.27% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

e2e/qgb/deployer_test.go Show resolved Hide resolved
e2e/qgb/deployer_test.go Show resolved Hide resolved
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@rach-id rach-id merged commit 3b3176c into celestiaorg:qgb-integration Jul 24, 2022
@rach-id rach-id deleted the config_flags branch July 24, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants