Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check protobuf generated code #561

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 25, 2022

Description

Resolves #560

Testing

Sample PR fails when a field was added to tx.proto but the corresponding generated file x/payment/types/tx.pb.go was not committed. See https://github.com/rootulp/celestia-app/runs/7506797210?check_suite_focus=true#step%3A3%3A68=


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@rootulp rootulp marked this pull request as ready for review July 25, 2022 20:30
@rootulp rootulp self-assigned this Jul 25, 2022
@evan-forbes evan-forbes added the CI item that directly relates to or modify the CI label Jul 26, 2022
@rootulp rootulp merged commit a366866 into celestiaorg:master Jul 27, 2022
@rootulp rootulp deleted the rp/proto-ci-2 branch July 27, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI item that directly relates to or modify the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: check that generated protobuf files match committed files
3 participants