Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to go 1.18 #573

Merged
merged 2 commits into from
Jul 27, 2022
Merged

chore: update to go 1.18 #573

merged 2 commits into from
Jul 27, 2022

Conversation

evan-forbes
Copy link
Member

Description

This PR updates this repo to use go 1.18. It also requires an update to golangci-linter in order for that to keep working.

closes #572
unblocks #472

@evan-forbes evan-forbes added the dependencies Pull requests that update a dependency file label Jul 27, 2022
@evan-forbes evan-forbes self-assigned this Jul 27, 2022
rootulp
rootulp previously approved these changes Jul 27, 2022
.github/workflows/lint.yml Outdated Show resolved Hide resolved
rach-id
rach-id previously approved these changes Jul 27, 2022
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI apparently only needs to be restarted to be green.

@evan-forbes evan-forbes dismissed stale reviews from rach-id and rootulp via c427536 July 27, 2022 20:31
Co-authored-by: Rootul Patel <rootulp@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #573 (c427536) into master (b953beb) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   28.87%   28.83%   -0.04%     
==========================================
  Files          16       16              
  Lines        2040     2039       -1     
==========================================
- Hits          589      588       -1     
  Misses       1392     1392              
  Partials       59       59              
Impacted Files Coverage Δ
x/payment/types/codec.go 100.00% <ø> (ø)
x/payment/types/events.go 0.00% <ø> (ø)
x/payment/types/genesis.go 100.00% <ø> (ø)
x/payment/types/verify_sigs.go 36.84% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@evan-forbes evan-forbes merged commit 01490be into master Jul 27, 2022
@evan-forbes evan-forbes deleted the evan/update-to-go-1.18 branch July 27, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update to go 1.18
4 participants