Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use build flags when running make build #582

Merged
merged 1 commit into from
Jul 29, 2022
Merged

fix: use build flags when running make build #582

merged 1 commit into from
Jul 29, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 29, 2022

Description

Closes #581

The $(BUILD_FLAGS) contain the version:

celestia-app/Makefile

Lines 13 to 20 in 5148c70

ldflags = -X github.com/cosmos/cosmos-sdk/version.Name=celestia-app \
-X github.com/cosmos/cosmos-sdk/version.AppName=celestia-appd \
-X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \
-X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \
-X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags_comma_sep)"
ldflags += $(LDFLAGS)
BUILD_FLAGS := -ldflags '$(ldflags)'

Testing

make build
$ ./build/celestia-appd version
0.6.0-11-gcfa991a

@rootulp rootulp added the bug Something isn't working label Jul 29, 2022
@rootulp rootulp requested a review from evan-forbes July 29, 2022 13:47
@rootulp rootulp self-assigned this Jul 29, 2022
@rootulp rootulp marked this pull request as ready for review July 29, 2022 13:47
@rootulp rootulp mentioned this pull request Jul 29, 2022
Closed
evan-forbes
evan-forbes approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doooooooppppppeeeeee utACK pre-approving pending CI

@rootulp rootulp merged commit ed8d270 into celestiaorg:master Jul 29, 2022
@rootulp rootulp deleted the rp/print-version branch August 29, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rootulp rootulp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

celestia-appd version doesn't display version
2 participants
@rootulp @evan-forbes