Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGB Relayer add commitments check when relaying confirms #613

Merged
merged 3 commits into from
Aug 31, 2022
Merged

QGB Relayer add commitments check when relaying confirms #613

merged 3 commits into from
Aug 31, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Aug 12, 2022

Adds a check on the confirms' commitments before relaying them

@rach-id rach-id added the C: QGB label Aug 12, 2022
@rach-id rach-id self-assigned this Aug 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022 •
edited
Loading

Codecov Report

Merging #613 (786f329) into qgb-integration (79b83d8) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           qgb-integration     #613   +/-   ##
================================================
  Coverage            10.93%   10.93%           
================================================
  Files                   57       57           
  Lines                 9240     9240           
================================================
  Hits                  1010     1010           
  Misses                8127     8127           
  Partials               103      103

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

adlerjohn
adlerjohn approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

evan-forbes
evan-forbes approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@rach-id
Copy link
Member Author

rach-id commented Aug 16, 2022

Will not merge until I get to the bottom of the commitments issue.

@rach-id rach-id force-pushed the check_confirms_when_relaying branch from 7eb9cca to 786f329 Compare August 17, 2022 22:44
@rach-id
Copy link
Member Author

rach-id commented Aug 17, 2022

We could even increase the validations we do on the commitments before adding them to make the relayer smarter and not just keep sending transactions to the EVM chain that we know won't pass.
What do you think? Should we create an issue for that?

@evan-forbes
Copy link
Member

We could even increase the validations we do on the commitments before adding them to make the relayer smarter and not just keep sending transactions to the EVM chain that we know won't pass.
What do you think? Should we create an issue for that?

hey sorry I missed this. Yeah, this sounds good! Perhaps this should be covered in ADR 005?

@rach-id rach-id merged commit 3bb9933 into celestiaorg:qgb-integration Aug 31, 2022
@rach-id rach-id deleted the check_confirms_when_relaying branch August 31, 2022 16:02
@rach-id rach-id mentioned this pull request Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@rootulp rootulp Awaiting requested review from rootulp

Assignees

@rach-id rach-id

Labels
None yet
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rach-id @codecov-commenter @evan-forbes @adlerjohn