Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable exportloopref #615

Merged
merged 1 commit into from
Aug 15, 2022
Merged

ci: enable exportloopref #615

merged 1 commit into from
Aug 15, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 15, 2022

Closes #323

This repo was already compliant with https://github.com/kyoh86/exportloopref so no code changes were necessary

@rootulp rootulp added the CI item that directly relates to or modify the CI label Aug 15, 2022
@rootulp rootulp self-assigned this Aug 15, 2022
@rootulp rootulp mentioned this pull request Aug 15, 2022
Closed
evan-forbes
evan-forbes approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with closing #323 after this, thanks for handling all of these @rootulp

@rootulp rootulp merged commit 2d7f477 into celestiaorg:main Aug 15, 2022
@rootulp rootulp deleted the rp/exportloopref branch August 15, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rootulp rootulp

Labels
CI item that directly relates to or modify the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add more linter checks
2 participants
@rootulp @evan-forbes