Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move share encoding logic from core -> app #627

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Aug 17, 2022

@codecov-commenter
Copy link

Codecov Report

Merging #627 (8a25644) into main (24bbf82) will increase coverage by 8.75%.
The diff coverage is 75.10%.

❗ Current head 8a25644 differs from pull request most recent head 421f233. Consider uploading reports for the commit 421f233 to get more accurate results

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   29.78%   38.53%   +8.75%     
==========================================
  Files          16       19       +3     
  Lines        2055     2543     +488     
==========================================
+ Hits          612      980     +368     
- Misses       1382     1478      +96     
- Partials       61       85      +24     
Impacted Files Coverage Δ
pkg/shares/shares.go 50.00% <50.00%> (ø)
pkg/shares/share_splitting.go 75.00% <75.00%> (ø)
pkg/shares/share_merging.go 77.11% <77.11%> (ø)
x/payment/types/payfordata.go 77.30% <100.00%> (+1.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Can you add to the PR description a permalink to the source of the code?

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

pkg/shares/shares_test.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move share encoding and decoding logic to the app
4 participants