Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused build flags #640

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 19, 2022

Closes #635
Closes #639

@rootulp rootulp self-assigned this Aug 19, 2022
@rootulp rootulp marked this pull request as ready for review August 19, 2022 19:42
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I guess that the test_ledger_mock was removed at some point in the cosmos-sdk and wasn't completely removed.
I tried finding any usage of the tag, couldn't find any.
@evan-forbes Any idea?

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idek remember when or how those got added.

LGTM 👍 👍 🪓 🪓

@rootulp rootulp merged commit 435e557 into celestiaorg:main Aug 19, 2022
@rootulp rootulp deleted the rp/test-flags branch August 19, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused build tags: ledger and test_ledger_mock Two Makefile test tasks
3 participants