-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add lint and fmt Makefile tasks #641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hell yeah how have we been living without this!!
do we want to add actually calling gofumpt -w
as well somewhere? I'd be fine with either not adding it, or maybe have some sort of differentiation between the commands that actually modify code and others that just let us know something is wrong. Either way 👍 👍
I agree, running linters with
Motivation: conforms to what celestia-node does here. Note: Line 8 in 435e557
|
Inspired by https://github.com/celestiaorg/celestia-node/blob/main/Makefile#L61-L74
Testing
I intentionally introduced a markdownlint violation