Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify naming of NextHighestPowerOf2 #649

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 22, 2022

Closes #648

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Aug 22, 2022
@rootulp rootulp self-assigned this Aug 22, 2022
@@ -46,10 +46,22 @@ func TestNextLowestPowerOf2(t *testing.T) {
expected uint64
}
tests := []test{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted in ascending order and added a test case for input 5

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #649 (d6d649d) into main (33e7416) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   38.45%   38.45%           
=======================================
  Files          19       19           
  Lines        2538     2538           
=======================================
  Hits          976      976           
  Misses       1476     1476           
  Partials       86       86           
Impacted Files Coverage Δ
x/payment/types/payfordata.go 77.20% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍

@rootulp rootulp merged commit ff2d92a into celestiaorg:main Aug 23, 2022
@rootulp rootulp deleted the rp/clarify-next-highest-power-of-2 branch August 23, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify naming of NextHighestPowerOf2
3 participants