Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant checks #665

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 26, 2022

Closes #664

Note these tests still pass:

// MsgPayForData that uses parity shares namespace id
paritySharesMsg := validMsgPayForData(t)
paritySharesMsg.MessageNamespaceId = []byte{0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF}
// MsgPayForData that uses tail padding namespace id
tailPaddingMsg := validMsgPayForData(t)
tailPaddingMsg.MessageNamespaceId = []byte{0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFE}

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Aug 26, 2022
@rootulp rootulp self-assigned this Aug 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #665 (6ad5686) into main (5a31cf0) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   38.45%   38.54%   +0.09%     
==========================================
  Files          19       19              
  Lines        2538     2532       -6     
==========================================
  Hits          976      976              
+ Misses       1476     1472       -4     
+ Partials       86       84       -2     
Impacted Files Coverage Δ
x/payment/types/payfordata.go 80.76% <100.00%> (+3.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@rootulp rootulp merged commit 301f9df into celestiaorg:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant checks when validating namespace
3 participants