Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement InfoReservedByte #671

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 29, 2022

Part of #659

@rootulp rootulp self-assigned this Aug 29, 2022
@rootulp rootulp changed the title Implement info reserved byte Implement InfoReservedByte Aug 29, 2022
@rootulp rootulp marked this pull request as ready for review August 29, 2022 19:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #671 (54dc074) into main (13076a6) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   36.06%   36.40%   +0.33%     
==========================================
  Files          24       25       +1     
  Lines        2623     2637      +14     
==========================================
+ Hits          946      960      +14     
  Misses       1594     1594              
  Partials       83       83              
Impacted Files Coverage Δ
pkg/shares/info_reserved_byte.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rootulp rootulp merged commit 3b7a3d8 into celestiaorg:main Aug 31, 2022
@rootulp rootulp deleted the rp/info-reserved-byte branch August 31, 2022 15:34
@rootulp rootulp changed the title Implement InfoReservedByte Implement InfoReservedByte Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants