chore: move malleated transaction decoder to the encoding package #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
adlerjohn,
rootulp,
liamsi,
mojtaba-esk,
rahulghangas and
rach-id
Codecov Report
@@ Coverage Diff @@
## main #690 +/- ##
=======================================
Coverage 40.49% 40.49%
=======================================
Files 28 28
Lines 2857 2857
=======================================
Hits 1157 1157
Misses 1611 1611
Partials 89 89 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it makes sense that we are keeping the custom decoder in the app package, since it is strictly related to encoding.
Moved this in the non-interactive defaults feature branch, but it should probably be its own PR.