chore: remove sims #697
Merged
chore: remove sims #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves celestiaorg#693
rootulp
added
the
chore
|
Will close in favor of #692 |
evan-forbes
reviewed
Sep 12, 2022
Yes. Likely https://github.com/celestiaorg/celestia-app/blob/main/Makefile#L76-L81 |
|
yeah, exactly, will approve after that is removed and the makefile works |
rootulp
commented
Sep 12, 2022
| include contrib/devtools/Makefile | ||
| include contrib/devtools/sims.mk | ||
|
|
||
| test-all: check test-race test-cover |
There was a problem hiding this comment.
check was removed b/c it is not defined in any of the Makefiles
rootulp
added a commit
that referenced
this pull request
Oct 10, 2022
I noticed that we no longer need a Makefile `PACKAGES` variable because this repo doesn't contain a `/simulation` directory. We removed sims from workflows in #697 but there wasn't a `/simulation` directory then either. This makes the `make test` command easier to copy + paste (if for instance you want to add a trailing `-count=1` flag to disable the cache) Note: cosmos-sdk uses PACKAGE variables [here](https://github.com/cosmos/cosmos-sdk/blob/main/Makefile#L3-L4) but celestia-app doesn't appear to need this extra complexity
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
I noticed that we no longer need a Makefile `PACKAGES` variable because this repo doesn't contain a `/simulation` directory. We removed sims from workflows in celestiaorg#697 but there wasn't a `/simulation` directory then either. This makes the `make test` command easier to copy + paste (if for instance you want to add a trailing `-count=1` flag to disable the cache) Note: cosmos-sdk uses PACKAGE variables [here](https://github.com/cosmos/cosmos-sdk/blob/main/Makefile#L3-L4) but celestia-app doesn't appear to need this extra complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #693