Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pkg)!: move wrapper package from core -> app #707

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

evan-forbes
Copy link
Member

similar to #706 and #702, we can move this package to the app since we're deleting all of the uses in core.

rootulp
rootulp previously approved these changes Sep 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #707 (61c81b7) into main (bf4fb49) will increase coverage by 0.38%.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   44.12%   44.51%   +0.38%     
==========================================
  Files          31       32       +1     
  Lines        3159     3188      +29     
==========================================
+ Hits         1394     1419      +25     
- Misses       1663     1666       +3     
- Partials      102      103       +1     
Impacted Files Coverage Δ
pkg/inclusion/nmt_caching.go 80.00% <ø> (ø)
pkg/prove/proof.go 83.82% <ø> (ø)
x/payment/types/payfordata.go 78.78% <ø> (ø)
pkg/wrapper/nmt_wrapper.go 86.20% <86.20%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evan-forbes evan-forbes merged commit 5ac7873 into main Sep 14, 2022
@evan-forbes evan-forbes deleted the evan/move-wrapper-pkg branch September 14, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants