Rename appconsts to use Compact and Sparse terminology
#710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #710 +/- ##
=======================================
Coverage 44.52% 44.52%
=======================================
Files 32 32
Lines 3189 3189
=======================================
Hits 1420 1420
Misses 1666 1666
Partials 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I would approve, but I want to ensure that Rachid's question or suggestion has a chance to be addressed before automerging, even if its non-blocking/orthogonal |
rootulp
added a commit
to rootulp/celestia-app
that referenced
this pull request
Sep 15, 2022
…rg#710) * feat: move share consts from celestia-core * feat: new consts for universal share encoding * remove universal share constants * address @sweexordious feedback
rootulp
added a commit
to rootulp/celestia-app
that referenced
this pull request
Sep 15, 2022
…elestiaorg#710)" This reverts commit 75e2b9d.
rootulp
added a commit
that referenced
this pull request
Sep 16, 2022
* Add ParseInfoReservedByte * Update split contiguous shares to account for info byte * Fix TestContigShareWriter test * Improve names in parseDataLength * Remove unused function parseDataLength * revert local celestia-core replace * docs: improve docs * docs: fix doc comments * feat: move share consts from celestia-core * feat: new consts for universal share encoding * remove universal share constants * fix: pass Test_parseSparseShares * Rename appconsts to use `Compact` and `Sparse` terminology (#710) * feat: move share consts from celestia-core * feat: new consts for universal share encoding * remove universal share constants * address @sweexordious feedback * Revert "Rename appconsts to use `Compact` and `Sparse` terminology (#710)" This reverts commit 75e2b9d. * revert change to exactMsgShareSize * fix: add info byte to namespace padded shares Makes `TestParsePaddedMsg` pass * pass first two test cases of TestMerge * pass: TestMerge * pass: TestTxInclusion by updating proof to use share pkg * pass: TestTxSharePosition * pass: Test_genRowShares * pass: Test_genOrigRowShares * use share package over types * pass: TestPrepareMessagesWithReservedNamespaces * pass: TestCreateCommitment by updating expected bytes * extract doc comments to separate PR * extract separate PR for specifying square size in shares_test.go * test: add TestMsgShareContainsInfoByte * test: add TestContiguousMsgShareContainsInfoByte * test: add compact share tests * throw error if isMessageStart != isNewMessage * throw error if compact share does not start with a share with isMessageStart=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShareReservedBytes=>CompactShareReservedBytesTxShareSize=>CompactShareContentSizeMsgShareSize=>SparseShareContentSize