Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: README for shares package #724

Merged
merged 4 commits into from
Sep 28, 2022
Merged

docs: README for shares package #724

merged 4 commits into from
Sep 28, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 16, 2022 •
edited
Loading

Closes #718

@rootulp rootulp self-assigned this Sep 16, 2022
@rootulp rootulp changed the title docs: initial README for shares package docs: README for shares package Sep 16, 2022
@celestiaorg celestiaorg deleted a comment from codecov-commenter Sep 20, 2022
@rootulp rootulp marked this pull request as ready for review September 28, 2022 01:20
@rootulp rootulp added the documentation Improvements or additions to documentation label Sep 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022 •
edited
Loading

Codecov Report

Merging #724 (f9e53b6) into main (595fd3b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   23.31%   23.29%   -0.02%     
==========================================
  Files          71       71              
  Lines        8792     8790       -2     
==========================================
- Hits         2050     2048       -2     
  Misses       6570     6570              
  Partials      172      172
Impacted Files Coverage Δ
x/payment/types/payfordata.go 76.33% <0.00%> (-0.36%) ⬇️
x/payment/types/square_sizes.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rach-id
rach-id previously approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only non blocking suggestions

pkg/shares/README.md Outdated Show resolved Hide resolved
pkg/shares/README.md Outdated Show resolved Hide resolved
evan-forbes
evan-forbes approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very well said! this is a huge value add imo

@rootulp rootulp merged commit 3dcce79 into celestiaorg:main Sep 28, 2022
@rootulp rootulp deleted the rp/share-readme branch September 28, 2022 14:34
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
@rootulp @rach-id
docs: README for shares package (celestiaorg#724)
11159e4 
Closes celestiaorg#718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@rach-id rach-id rach-id left review comments

Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README for pkg/shares
4 participants
@rootulp @codecov-commenter @rach-id @evan-forbes