Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB Feedback on PR #742 #746

Merged
merged 27 commits into from
Sep 21, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Sep 20, 2022

This PR contains the feedback for the #742

@rach-id rach-id added the C: QGB label Sep 20, 2022
@rach-id rach-id self-assigned this Sep 20, 2022
@rach-id
Copy link
Member Author

rach-id commented Sep 20, 2022

For the empty proto comments, they're required by proto linter:

{"path":"proto/qgb/query.proto","start_line":45,"start_column":1,"end_line":45,"end_column":30,"type":"COMMENT_MESSAGE","message":"Message \"QueryParamsRequest\" should have a non-empty comment for documentation."}
{"path":"proto/qgb/query.proto","start_line":47,"start_column":1,"end_line":49,"end_column":2,"type":"COMMENT_MESSAGE","message":"Message \"QueryParamsResponse\" should have a non-empty comment for documentation."}
{"path":"proto/qgb/query.proto","start_line":51,"start_column":1,"end_line":51,"end_column":68,"type":"COMMENT_MESSAGE","message":"Message \"QueryAttestationRequestByNonceRequest\" should have a non-empty comment for documentation."}
{"path":"proto/qgb/query.proto","start_line":53,"start_column":1,"end_line":59,"end_column":2,"type":"COMMENT_MESSAGE","message":"Message \"QueryAttestationRequestByNonceResponse\" should have a non-empty comment for documentation."}
{"path":"proto/qgb/query.proto","start_line":61,"start_column":1,"end_line":61,"end_column":46,"type":"COMMENT_MESSAGE","message":"Message \"QueryLatestAttestationNonceRequest\" should have a non-empty comment for documentation."}
{"path":"proto/qgb/query.proto","start_line":63,"start_column":1,"end_line":63,"end_column":66,"type":"COMMENT_MESSAGE","message":"Message \"QueryLatestAttestationNonceResponse\" should have a non-empty comment for documentation."}
{"path":"proto/qgb/query.proto","start_line":73,"start_column":1,"end_line":73,"end_column":43,"type":"COMMENT_MESSAGE","message":"Message \"QueryLastUnbondingHeightRequest\" should have a non-empty comment for documentation."}
{"path":"proto/qgb/query.proto","start_line":75,"start_column":1,"end_line":75,"end_column":64,"type":"COMMENT_MESSAGE","message":"Message \"QueryLastUnbondingHeightResponse\" should have a non-empty comment for documentation."}

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my feedback was addressed, but will wait for approval from other reviewers for final approval

Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for addressing all the nits!

x/qgb/keeper/hooks.go Outdated Show resolved Hide resolved
Co-authored-by: Rootul P <rootulp@gmail.com>
@rach-id rach-id merged commit bfa216f into celestiaorg:qgb-integration Sep 21, 2022
@rach-id rach-id deleted the qgb_merge_feedback_1 branch September 21, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants