Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qgb universal nonces ADR update #748

Merged
merged 8 commits into from
Sep 21, 2022
Merged

Qgb universal nonces ADR update #748

merged 8 commits into from
Sep 21, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Sep 21, 2022 •
edited

Closing #471

@rach-id rach-id added documentation Improvements or additions to documentation C: QGB labels Sep 21, 2022
@rach-id rach-id self-assigned this Sep 21, 2022
rootulp
rootulp approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for publishing this ADR! It really helps clarify the implementation details behind universal nonces.

All my feedback is optional and non-blocking

docs/architecture/ADR-004-QGB_relayer_security.md Show resolved Hide resolved
docs/architecture/ADR-004-QGB_relayer_security.md Show resolved Hide resolved
docs/architecture/ADR-004-QGB_relayer_security.md Outdated Show resolved Hide resolved
docs/architecture/ADR-004-QGB_relayer_security.md Outdated Show resolved Hide resolved
docs/architecture/ADR-004-QGB_relayer_security.md Outdated Show resolved Hide resolved
docs/architecture/ADR-004-QGB_relayer_security.md Outdated Show resolved Hide resolved
docs/architecture/ADR-004-QGB_relayer_security.md Outdated Show resolved Hide resolved
docs/architecture/ADR-004-QGB_relayer_security.md Outdated Show resolved Hide resolved
@rach-id rach-id mentioned this pull request Sep 21, 2022
Closed
rach-id and others added 6 commits September 21, 2022 17:26
@rach-id @rootulp
Update docs/architecture/ADR-004-QGB_relayer_security.md
2f7b5b7 
Co-authored-by: Rootul P <rootulp@gmail.com>
@rach-id @rootulp
Update docs/architecture/ADR-004-QGB_relayer_security.md
87f000d 
Co-authored-by: Rootul P <rootulp@gmail.com>
@rach-id @rootulp
Update docs/architecture/ADR-004-QGB_relayer_security.md
c5983d6 
Co-authored-by: Rootul P <rootulp@gmail.com>
@rach-id @rootulp
Update docs/architecture/ADR-004-QGB_relayer_security.md
251523f 
Co-authored-by: Rootul P <rootulp@gmail.com>
@rach-id @rootulp
Update docs/architecture/ADR-004-QGB_relayer_security.md
8c68625 
Co-authored-by: Rootul P <rootulp@gmail.com>
@rach-id @rootulp
Update docs/architecture/ADR-004-QGB_relayer_security.md
b95e447 
Co-authored-by: Rootul P <rootulp@gmail.com>
@rach-id rach-id merged commit 69c8d28 into celestiaorg:qgb-integration Sep 21, 2022
@rach-id rach-id deleted the qgb_universal_nonces_adr_edit branch September 21, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rach-id rach-id

Labels
documentation Improvements or additions to documentation
Projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rach-id @rootulp @evan-forbes