-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QGB nits + docs for the merge 2 #753
Conversation
# Conflicts: # x/qgb/keeper/keeper_attestation.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve after:
- File is go formatted
- Negate check
Co-authored-by: Rootul P <rootulp@gmail.com>
@rootulp Sorry, wasn't focusing earlier. The best we can do to refactor is: store := ctx.KVStore(k.storeKey)
if k.CheckLatestAttestationNonce(ctx) {
if k.GetLatestAttestationNonce(ctx)+1 != nonce {
panic("not incrementing latest attestation nonce correctly")
}
store.Set([]byte(types.LatestAttestationtNonce), types.UInt64Bytes(nonce))
}
store.Set([]byte(types.LatestAttestationtNonce), types.UInt64Bytes(nonce)) But I don't think it is worth it. |
If you don't mind, I can rename this PR to contain extra nits that are taken from the Merge PR. |
Codecov Report
@@ Coverage Diff @@
## qgb-integration #753 +/- ##
===================================================
+ Coverage 12.60% 22.36% +9.75%
===================================================
Files 45 62 +17
Lines 6448 7665 +1217
===================================================
+ Hits 813 1714 +901
- Misses 5550 5809 +259
- Partials 85 142 +57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…nt power change in valset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice additions
No description provided.