Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Go mod tidy on QGB branch #767

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Sep 22, 2022

I was using go 1.19 and also the version of the cosmos-sdk specified wasn't right.

@rach-id rach-id self-assigned this Sep 22, 2022
@rach-id rach-id added the C: QGB label Sep 22, 2022
@rach-id
Copy link
Member Author

rach-id commented Sep 22, 2022

@codecov-commenter
Copy link

Codecov Report

Merging #767 (7bd08a3) into qgb-integration (d94943d) will decrease coverage by 0.97%.
The diff coverage is n/a.

❗ Current head 7bd08a3 differs from pull request most recent head 8079d56. Consider uploading reports for the commit 8079d56 to get more accurate results

@@                 Coverage Diff                 @@
##           qgb-integration     #767      +/-   ##
===================================================
- Coverage            23.33%   22.36%   -0.98%     
===================================================
  Files                   71       62       -9     
  Lines                 8801     7665    -1136     
===================================================
- Hits                  2054     1714     -340     
+ Misses                6575     5809     -766     
+ Partials               172      142      -30     
Impacted Files Coverage Δ
pkg/shares/utils.go 4.08% <0.00%> (-22.45%) ⬇️
pkg/shares/share_splitting.go 59.75% <0.00%> (-4.17%) ⬇️
app/module.go
app/export.go
app/process_proposal.go
app/app.go
app/prepare_proposal.go
app/malleate_txs.go
app/parse_txs.go
app/test_util.go
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rach-id rach-id merged commit a8b1ad8 into celestiaorg:qgb-integration Sep 22, 2022
@rach-id rach-id deleted the go_mod branch September 22, 2022 13:30
@rootulp
Copy link
Collaborator

rootulp commented Sep 22, 2022

I was using go 1.19 and also the version of the cosmos-sdk specified wasn't right.

FWIW celestia-node has upgraded to Go 1.19 (ref) so it seems like time for us to consider upgrading as well #769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants