Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: rename k to square_size #774

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 23, 2022

Closes #687

@rootulp rootulp self-assigned this Sep 23, 2022
@rootulp rootulp marked this pull request as draft September 23, 2022 15:04
@codecov-commenter
Copy link

Codecov Report

Merging #774 (c701cd3) into main (53d688e) will not change coverage.
The diff coverage is 72.22%.

@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   23.24%   23.24%           
=======================================
  Files          71       71           
  Lines        8796     8796           
=======================================
  Hits         2045     2045           
  Misses       6578     6578           
  Partials      173      173           
Impacted Files Coverage Δ
x/payment/types/tx.pb.go 18.04% <44.44%> (ø)
x/payment/types/verify_sigs.go 36.84% <100.00%> (ø)
x/payment/types/wirepayfordata.go 66.35% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp changed the title chore!: rename k to square_size chore!: rename k to square_size Sep 23, 2022
@rootulp rootulp marked this pull request as ready for review September 23, 2022 15:36
@rootulp rootulp enabled auto-merge (squash) September 23, 2022 15:36
@rootulp rootulp merged commit 93e02ad into celestiaorg:main Sep 23, 2022
@rootulp rootulp deleted the rp/square-size branch September 23, 2022 19:14
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a single name for each variable that references square size
3 participants