fix: compact share Count
#778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
bug
Codecov Report
@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 23.24% 23.29% +0.05%
==========================================
Files 71 71
Lines 8796 8790 -6
==========================================
+ Hits 2045 2048 +3
+ Misses 6578 6570 -8
+ Partials 173 172 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
previously approved these changes
Sep 23, 2022
app/estimate_square_size.go
Outdated
Comment on lines
95
to
96
| txCount := txSplitter.Count() | ||
| evdCount := evdSplitter.Count() |
There was a problem hiding this comment.
[optional]
combine with return statement
evan-forbes
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #777
I choose to fix the implementation to match the doc comment because it seems like a leaky abstraction for this function to also return the # of available bytes in the pending share. By removing the second return value, the compact share
Countmore closely matches the sparse shareCountfunction signature.