fix: joinByteSlice implementation
#791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
commented
Sep 26, 2022
| // slice. | ||
| func stripCompactShares(compactShares [][]byte, start uint64, end uint64) (result []byte) { | ||
| for i := start; i <= end; i++ { | ||
| result = append(result, compactShares[i][appconsts.NamespaceSize+appconsts.ShareInfoBytes+appconsts.CompactShareReservedBytes:]...) |
There was a problem hiding this comment.
[for reviewers] note we don't need to parse the unit length delimiter that is prefixed to a transaction because the test checks that this share range contains the raw tx bytes. Therefore, it is safe to keep the unit length delimiter in the stripped compact shares returned from this function
Codecov Report
@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 23.28% 23.28%
=======================================
Files 71 71
Lines 8788 8788
=======================================
Hits 2046 2046
Misses 6570 6570
Partials 172 172 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #789