Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename InfoReservedByte to InfoByte #805

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 28, 2022

Closes #787

@rootulp rootulp self-assigned this Sep 28, 2022
@rootulp rootulp marked this pull request as ready for review September 28, 2022 18:59
@rootulp rootulp enabled auto-merge (squash) September 28, 2022 19:00
@codecov-commenter
Copy link

Codecov Report

Merging #805 (47487da) into main (b6698d6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   23.29%   23.29%           
=======================================
  Files          71       71           
  Lines        8790     8790           
=======================================
  Hits         2048     2048           
  Misses       6570     6570           
  Partials      172      172           
Impacted Files Coverage Δ
pkg/shares/info_byte.go 100.00% <100.00%> (ø)
pkg/shares/parse_compact_shares.go 66.66% <100.00%> (ø)
pkg/shares/parse_sparse_shares.go 80.00% <100.00%> (ø)
pkg/shares/split_compact_shares.go 84.24% <100.00%> (ø)
pkg/shares/split_sparse_shares.go 68.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I think my brain ignored the Reserved when reading it as this is what I though it was the whole time lol

@rootulp rootulp merged commit 8e0498c into celestiaorg:main Sep 29, 2022
@rootulp rootulp deleted the rp/rename-info-byte branch September 29, 2022 14:02
rootulp added a commit to rootulp/celestia-app that referenced this pull request Sep 29, 2022
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename InfoReservedByte to InfoByte
3 participants