Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: describe message length varint #806

Merged
merged 2 commits into from
Oct 19, 2022
Merged

docs: describe message length varint #806

merged 2 commits into from
Oct 19, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 28, 2022

Closes #728

@rootulp rootulp added the documentation Improvements or additions to documentation label Sep 28, 2022
@rootulp rootulp self-assigned this Sep 28, 2022
@rootulp rootulp added the specs directly relevant to the specs label Sep 28, 2022
rach-id
rach-id reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a question

specs/src/specs/data_structures.md Show resolved Hide resolved
rach-id
rach-id approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rootulp
Copy link
Collaborator Author

rootulp commented Oct 5, 2022

Will wait for @adlerjohn 's approval b/c he's the spec wizard

@rootulp rootulp mentioned this pull request Oct 11, 2022
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Oct 19, 2022

Will merge this as-is to unblock #856. If @adlerjohn has feedback, I can create follow-up PRs.

@rootulp rootulp merged commit eb3791e into celestiaorg:specs-staging Oct 19, 2022
@rootulp rootulp deleted the rp/specs-message-length-delim branch October 19, 2022 16:12
@rootulp rootulp mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi left review comments

@rach-id rach-id rach-id approved these changes

@egypjoy egypjoy egypjoy approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation specs directly relevant to the specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rootulp @liamsi @rach-id @egypjoy