fix: reserved byte for existing test cases #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: add test case for reserved byte that is not 14
evan-forbes
approved these changes
Sep 30, 2022
Comment on lines
+170
to
+173
| // maybeWriteReservedByteToPendingShare will be a no-op if the reserved byte has | ||
| // already been populated. If the reserved byte is empty, it will write the | ||
| // location of the next unit of data to the reserved byte. | ||
| func (css *CompactShareSplitter) maybeWriteReservedByteToPendingShare() { |
There was a problem hiding this comment.
admittedly the naming for this maybe weird, but I also don't have any better options. hopefully whenever we have more time to refactor this we can and just have a method to write the reserved byte
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #817