chore: resolve local lint issues #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Resolve the following issues observed on `make lint` ``` --> Running linter pkg/inclusion/paths.go:49: File is not `gofumpt`-ed (gofumpt) // The following nolint can be removed after this function is used. pkg/inclusion/paths.go:68: File is not `gofumpt`-ed (gofumpt) // / \ // / \ pkg/inclusion/paths.go:71: File is not `gofumpt`-ed (gofumpt) // /\ /\ x/payment/keeper/keeper.go:31: File is not `gofumpt`-ed (gofumpt) // MsgPayForData moves a user's coins to the module address and burns them. app/export.go:49: File is not `gofumpt`-ed (gofumpt) // in favour of export at a block height make: *** [lint] Error 1 ``` These lines haven't been modified recently. It's not clear to me why these issues haven't been flagged by lint on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the following issues observed on
make lintThese lines haven't been modified recently. It's not clear to me why these issues haven't been flagged by lint on CI.