Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move ParseDelimiter #841

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 6, 2022

Move ParseDelimiter from parse_sparse_shares to utils.go because it is used when parsing sparse and compact shares

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Oct 6, 2022
@rootulp rootulp requested a review from rach-id October 6, 2022 01:34
@rootulp rootulp self-assigned this Oct 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #841 (2d433f0) into main (d8a9272) will not change coverage.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   25.63%   25.63%           
=======================================
  Files          75       75           
  Lines        9279     9279           
=======================================
  Hits         2379     2379           
  Misses       6677     6677           
  Partials      223      223           
Impacted Files Coverage Δ
pkg/shares/parse_sparse_shares.go 77.77% <ø> (+1.58%) ⬆️
pkg/shares/utils.go 48.14% <71.42%> (+8.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp enabled auto-merge (squash) October 6, 2022 02:47
@rootulp rootulp merged commit 22a48e4 into celestiaorg:main Oct 6, 2022
@rootulp rootulp deleted the rp/move-parse-delim branch October 6, 2022 14:48
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
Move `ParseDelimiter` from `parse_sparse_shares` to `utils.go` because
it is used when parsing sparse and compact shares
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants