Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc comment on SparseShare vs CompactShare #844

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 6, 2022

ADR007 merged and the share package has a README (soon to be godoc package comment) so this doc comment no longer seems necessary

ADR007 merged and the share package has a README (soon to be godoc package comment) so this doc comment no longer seems necessary
@rootulp rootulp added documentation Improvements or additions to documentation chore optional label for items that follow the `chore` conventional commit labels Oct 6, 2022
@rootulp rootulp requested a review from rach-id October 6, 2022 18:47
@rootulp rootulp self-assigned this Oct 6, 2022
@rootulp rootulp enabled auto-merge (squash) October 6, 2022 18:47
@rootulp rootulp merged commit 5e02380 into main Oct 6, 2022
@rootulp rootulp deleted the rp/remove-doc branch October 6, 2022 18:50
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
ADR007 merged and the share package has a README (soon to be godoc
package comment) so this doc comment no longer seems necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants