fix: remove debug printf statement #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This printf statement was accidentally introduced in celestiaorg#781 It should be removed to avoid log spam when developers run `make test`
rootulp
added
bug
rootulp
commented
Oct 9, 2022
| @@ -109,7 +108,6 @@ func txSharePosition(txs types.Txs, txIndex uint64) (startSharePos, endSharePos | |||
|
|
|||
| startSharePos = txShareIndex(prevTxTotalLen) | |||
| endSharePos = txShareIndex(endOfCurrentTxLen) | |||
| fmt.Printf("prevTxTotalLen: %d, endOfCurrentTxLen: %d, startSharePos: %d, endSharePos %d, currentTxTotalLen %d\n", prevTxTotalLen, endOfCurrentTxLen, startSharePos, endSharePos, currentTxTotalLen) | |||
There was a problem hiding this comment.
[informational] when you run make test the output gets polluted with many lines of the form
ok github.com/celestiaorg/celestia-app/pkg/inclusion (cached)
prevTxTotalLen: 0, endOfCurrentTxLen: 82, startSharePos: 0, endSharePos 0, currentTxTotalLen 82
prevTxTotalLen: 82, endOfCurrentTxLen: 172, startSharePos: 0, endSharePos 0, currentTxTotalLen 90
prevTxTotalLen: 172, endOfCurrentTxLen: 562, startSharePos: 0, endSharePos 1, currentTxTotalLen 390
prevTxTotalLen: 562, endOfCurrentTxLen: 697, startSharePos: 1, endSharePos 1, currentTxTotalLen 135
prevTxTotalLen: 697, endOfCurrentTxLen: 956, startSharePos: 1, endSharePos 1, currentTxTotalLen 259
prevTxTotalLen: 956, endOfCurrentTxLen: 1004, startSharePos: 1, endSharePos 2, currentTxTotalLen 48
prevTxTotalLen: 1004, endOfCurrentTxLen: 1081, startSharePos: 2, endSharePos 2, currentTxTotalLen 77
prevTxTotalLen: 1081, endOfCurrentTxLen: 1350, startSharePos: 2, endSharePos 2, currentTxTotalLen 269
prevTxTotalLen: 1350, endOfCurrentTxLen: 1481, startSharePos: 2, endSharePos 2, currentTxTotalLen 131
prevTxTotalLen: 1481, endOfCurrentTxLen: 1635, startSharePos: 2, endSharePos 3, currentTxTotalLen 154
prevTxTotalLen: 1635, endOfCurrentTxLen: 1818, startSharePos: 3, endSharePos 3, currentTxTotalLen 183
...
rach-id
approved these changes
Oct 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
==========================================
- Coverage 25.59% 25.58% -0.01%
==========================================
Files 75 75
Lines 9273 9272 -1
==========================================
- Hits 2373 2372 -1
Misses 6677 6677
Partials 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
This printf statement was accidentally introduced in celestiaorg#781 It should be removed to avoid log spam when developers run `make test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This printf statement was accidentally introduced in #781
It should be removed to avoid log spam when developers run
make test