chore: rename data length to sequence length #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivaiton: "sequence length" is more precise than "data length"
rootulp
added
the
chore
rootulp
requested review from
liamsi,
adlerjohn,
MSevey and
evan-forbes
as code owners
MSevey
reviewed
Oct 12, 2022
| @@ -114,7 +114,7 @@ Types | |||
| Logic | |||
|
|
|||
| 1. Account for the new `InfoByte` in all share splitting and merging code. | |||
| 1. Encode a total data length varint into the first compact share of a sequence. | |||
| 1. Encode a total sequence length varint into the first compact share of a sequence. | |||
There was a problem hiding this comment.
Suggested change
| 1. Encode a total sequence length varint into the first compact share of a sequence. | |
| 1. Encode a total sequence length variant into the first compact share of a sequence. |
There was a problem hiding this comment.
or is this short for variable integer?
There was a problem hiding this comment.
varint is short for variable-width integer. I think variable-length integer is also often used.
Ref: https://developers.google.com/protocol-buffers/docs/encoding#varints
evan-forbes
approved these changes
Oct 13, 2022
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Motivaiton: "sequence length" is more precise than "data length"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivaiton: "sequence length" is more precise than "data length"