-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: throw error if incorrect sequenceLength #865
Conversation
Codecov Report
@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 25.82% 26.15% +0.32%
==========================================
Files 75 75
Lines 9296 9344 +48
==========================================
+ Hits 2401 2444 +43
+ Misses 6675 6674 -1
- Partials 220 226 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
8fdd71d
to
aa5f278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[comment]
switching from message to sequence is good and makes more sense for universal shares imo
had a few preliminary questions even tho this is still a draft. so far LGTM!
Closes #839