Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw error if incorrect sequenceLength #865

Merged
merged 9 commits into from
Oct 17, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 12, 2022

Closes #839

@rootulp rootulp self-assigned this Oct 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #865 (3bb4e5a) into main (3598fe2) will increase coverage by 0.32%.
The diff coverage is 72.58%.

@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
+ Coverage   25.82%   26.15%   +0.32%     
==========================================
  Files          75       75              
  Lines        9296     9344      +48     
==========================================
+ Hits         2401     2444      +43     
+ Misses       6675     6674       -1     
- Partials      220      226       +6     
Impacted Files Coverage Δ
pkg/shares/parse_sparse_shares.go 77.77% <0.00%> (ø)
pkg/shares/split_sparse_shares.go 67.96% <0.00%> (ø)
pkg/shares/shares.go 68.29% <20.00%> (+13.29%) ⬆️
pkg/shares/share_merging.go 76.50% <79.16%> (+0.87%) ⬆️
pkg/shares/info_byte.go 100.00% <100.00%> (ø)
pkg/shares/parse_compact_shares.go 66.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[comment]
switching from message to sequence is good and makes more sense for universal shares imo

had a few preliminary questions even tho this is still a draft. so far LGTM!

pkg/shares/share_merging.go Outdated Show resolved Hide resolved
pkg/shares/share_merging.go Show resolved Hide resolved
@rootulp rootulp marked this pull request as ready for review October 16, 2022 18:44
@rootulp rootulp merged commit ded7346 into celestiaorg:main Oct 17, 2022
@rootulp rootulp deleted the rp/parse-share-error branch October 17, 2022 21:16
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ParseShare should return an error if total sequence length varint doesn't match actual
3 participants