docs: update code block in ADR-006 #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
reviewed
Oct 17, 2022
evan-forbes
reviewed
Oct 17, 2022
There was a problem hiding this comment.
Question for reviewers: do we treat ADRs as a snapshot in time or should we update them to reflect changes that take place after the ADR was reviewed?
we can do both, as that's what tendermint and cosmos do. Updating can be tedious, and we should only do it if it makes sense (or is requested) or leave them as good beginner issues imo
evan-forbes
reviewed
Oct 17, 2022
| @@ -1,3 +1,5 @@ | |||
| "default": true # Default state for all rules | |||
| "MD010": | |||
| "code_blocks": false # Disable rule for hard tabs in code blocks | |||
evan-forbes
approved these changes
Oct 17, 2022
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Addresses informalsystems/audit-celestia#20 (comment) Question for reviewers: do we treat ADRs as a snapshot in time or should we update them to reflect changes that take place after the ADR was reviewed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses informalsystems/audit-celestia#20 (comment)
Question for reviewers: do we treat ADRs as a snapshot in time or should we update them to reflect changes that take place after the ADR was reviewed?