refactor: remove count from spare share splitter #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
commented
Oct 25, 2022
Comment on lines
-140
to
-150
| func TestMsgShareContainsInfoByte(t *testing.T) { | ||
| sss := NewSparseShareSplitter() | ||
| smallMsg := generateRandomMessage(appconsts.SparseShareContentSize / 2) | ||
| sss.Write(smallMsg) | ||
|
|
||
| shares := sss.Export() | ||
|
|
||
| got := shares[0][appconsts.NamespaceSize : appconsts.NamespaceSize+appconsts.ShareInfoBytes][0] | ||
|
|
||
| isSequenceStart := true | ||
| want, err := NewInfoByte(appconsts.ShareVersion, isSequenceStart) |
There was a problem hiding this comment.
Apologies for including a refactor to the info byte tests while implementing TestSparseShareSplitterCount. The refactor can be extracted to a separate PR if requested.
Codecov Report
@@ Coverage Diff @@
## main #911 +/- ##
=======================================
Coverage 26.09% 26.09%
=======================================
Files 77 77
Lines 9344 9341 -3
=======================================
Hits 2438 2438
+ Misses 6677 6674 -3
Partials 229 229
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #873
Closes informalsystems/audit-celestia#20