Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move TestProcessWirePayForData #921

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 26, 2022

Description

  1. Rename TestProcessMessage to TestProcessWirePayForData so that the test name matches the function under test
  2. Move the test to wirepayfordata_test.go because it is applicable to WirePayForData not PayForData

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Oct 26, 2022
@rootulp rootulp requested a review from rach-id October 26, 2022 14:38
@rootulp rootulp self-assigned this Oct 26, 2022
@rootulp rootulp enabled auto-merge (squash) October 26, 2022 14:39
@codecov-commenter
Copy link

Codecov Report

Merging #921 (802d778) into main (b63bca1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   26.11%   26.11%           
=======================================
  Files          77       77           
  Lines        9347     9347           
=======================================
  Hits         2441     2441           
  Misses       6677     6677           
  Partials      229      229           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rootulp rootulp merged commit 9769b75 into celestiaorg:main Oct 31, 2022
@rootulp rootulp deleted the rp/move-test-process-wire-pay-for-data branch October 31, 2022 19:13
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
## Description
1. Rename `TestProcessMessage` to `TestProcessWirePayForData` so that
the test name matches the function under test
2. Move the test to `wirepayfordata_test.go` because it is applicable to
WirePayForData not PayForData
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
## Description
1. Rename `TestProcessMessage` to `TestProcessWirePayForData` so that
the test name matches the function under test
2. Move the test to `wirepayfordata_test.go` because it is applicable to
WirePayForData not PayForData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants