feat!: square size independent message commitments #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
force-pushed
the
rp/square-size-independent-commitments-2
branch
2 times, most recently
from
ac52881
to
c64ed25
Compare
rootulp
commented
Oct 31, 2022
app/test/fuzz_abci_test.go
Outdated
| @@ -25,7 +25,7 @@ func TestFuzzPrepareProcessProposal(t *testing.T) { | |||
| encConf := encoding.MakeConfig(app.ModuleEncodingRegisters...) | |||
| signer := testutil.GenerateKeyringSigner(t, testAccName) | |||
| testApp := testutil.SetupTestAppWithGenesisValSet(t) | |||
| timer := time.After(time.Second * 30) | |||
| timer := time.After(time.Second * 10) | |||
There was a problem hiding this comment.
[for reviewers] VSCode default test timeout is 30 seconds so this test would timeout prior to completing. Decreased to 10 seconds so that it's possible to run inside VSCode. Can revert if desired.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rootulp
force-pushed
the
rp/square-size-independent-commitments-2
branch
from
c64ed25
to
777b3c0
Compare
rootulp
added
C: Celestia app
warn:api breaking
rach-id
reviewed
Nov 1, 2022
app/test/fuzz_abci_test.go
Outdated
| @@ -25,7 +25,7 @@ func TestFuzzPrepareProcessProposal(t *testing.T) { | |||
| encConf := encoding.MakeConfig(app.ModuleEncodingRegisters...) | |||
| signer := testutil.GenerateKeyringSigner(t, testAccName) | |||
| testApp := testutil.SetupTestAppWithGenesisValSet(t) | |||
| timer := time.After(time.Second * 30) | |||
| timer := time.After(time.Second * 10) | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Sorry I can't comment on #937 (comment) but thanks for the tip! I reverted this test timeout decrease and changed my local VSCode go test timeout config. |
rach-id
approved these changes
Nov 1, 2022
rootulp
changed the base branch from
main
to
feat/square-size-independent-commitments
evan-forbes
approved these changes
Nov 1, 2022
- remove one type conversion by adopting generics - remove unnecessary check
evan-forbes
approved these changes
Nov 7, 2022
|
Does this PR preserve the current non-interactive default rules? As mentioned in #941 (comment), the current non-interactive default rules may be required to ensure that message inclusion proofs remain O(log(n)). |
|
@musalbas good question and thanks for checking on this. This PR does not change the existing non-interactive defaults. This function and its usage remains unmodified https://github.com/rootulp/celestia-app/blob/671bc800acecfdeef426db580811fc0baeeda037/pkg/shares/non_interactive_defaults.go#L39-L80 only code relating to which subtree roots are used to calculate the commitment has been changed. |
|
Will merge this to the feature branch |
rootulp
added a commit
that referenced
this pull request
Nov 8, 2022
Implementation for square size independent message commitments. Note this targets `feat/square-size-independent-commitments` per #941 so that we can unblock review. <img src="https://user-images.githubusercontent.com/3699047/198996002-f20086af-187d-4ccf-adff-8f73b834152f.png" width="500">
rootulp
added a commit
that referenced
this pull request
Nov 9, 2022
If ADR 008 is adopted, only one message share commitment is signed so this PR renames a plural function to be singular. This is a follow-up to #937 and could've been included in that PR. Note: targets feature branch
2 tasks
rootulp
added a commit
that referenced
this pull request
Nov 11, 2022
Closes #941 ## Description This merges the feature branch `feat/square-size-independent-commitments` to `main`. The feature branch includes 3 already approved PRs: - #937 - #983 - #982 and two additional commits that haven't been reviewed yet to resolve the tasks below ## Tasks - [x] Merge in `main` and resolve merge conflicts caused by renames: - `payForData` => `payForBlob` - `x/payment` => `x/blob` - [x] Update ADR 008 to describe that it was implemented Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
…elestiaorg#984) Closes celestiaorg#941 ## Description This merges the feature branch `feat/square-size-independent-commitments` to `main`. The feature branch includes 3 already approved PRs: - celestiaorg#937 - celestiaorg#983 - celestiaorg#982 and two additional commits that haven't been reviewed yet to resolve the tasks below ## Tasks - [x] Merge in `main` and resolve merge conflicts caused by renames: - `payForData` => `payForBlob` - `x/payment` => `x/blob` - [x] Update ADR 008 to describe that it was implemented Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
…elestiaorg#984) Closes celestiaorg#941 ## Description This merges the feature branch `feat/square-size-independent-commitments` to `main`. The feature branch includes 3 already approved PRs: - celestiaorg#937 - celestiaorg#983 - celestiaorg#982 and two additional commits that haven't been reviewed yet to resolve the tasks below ## Tasks - [x] Merge in `main` and resolve merge conflicts caused by renames: - `payForData` => `payForBlob` - `x/payment` => `x/blob` - [x] Update ADR 008 to describe that it was implemented Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
cmwaters
pushed a commit
to celestiaorg/go-square
that referenced
this pull request
Dec 14, 2023
Closes celestiaorg/celestia-app#941 ## Description This merges the feature branch `feat/square-size-independent-commitments` to `main`. The feature branch includes 3 already approved PRs: - celestiaorg/celestia-app#937 - celestiaorg/celestia-app#983 - celestiaorg/celestia-app#982 and two additional commits that haven't been reviewed yet to resolve the tasks below ## Tasks - [x] Merge in `main` and resolve merge conflicts caused by renames: - `payForData` => `payForBlob` - `x/payment` => `x/blob` - [x] Update ADR 008 to describe that it was implemented Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for square size independent message commitments. Note this targets
feat/square-size-independent-commitmentsper #941 so that we can unblock review.