Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specs: two reserved bytes #939

Merged
merged 4 commits into from
Nov 24, 2022
Merged

specs: two reserved bytes #939

merged 4 commits into from
Nov 24, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 31, 2022

Closes #883

@rootulp rootulp added the specs directly relevant to the specs label Oct 31, 2022
@rootulp rootulp self-assigned this Oct 31, 2022
@rootulp rootulp marked this pull request as ready for review October 31, 2022 21:37
rach-id
rach-id reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left non blocking comments.
Will defer to others for approval

specs/src/specs/data_structures.md Outdated Show resolved Hide resolved
specs/src/specs/data_structures.md Outdated Show resolved Hide resolved
@rootulp @rach-id
Update specs/src/specs/data_structures.md
3792959 
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
rach-id
rach-id reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Deferring to other reviewers

MSevey
MSevey previously approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine, and based on the Issue I assume the spec changes were all previously validated.

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 3, 2022

Thanks for reviewing Matt! Will merge by end of next week to give @adlerjohn time to review.

evan-forbes
evan-forbes approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 24, 2022

Will merge tomorrow if @adlerjohn has no more feedback

@rootulp rootulp merged commit 3206843 into celestiaorg:specs-staging Nov 24, 2022
@rootulp rootulp deleted the rp/specs-two-reserved-bytes branch November 24, 2022 20:40
@evan-forbes evan-forbes mentioned this pull request Dec 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@liamsi liamsi liamsi approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@MSevey MSevey MSevey left review comments

@rach-id rach-id Awaiting requested review from rach-id

Assignees

@rootulp rootulp

Labels
specs directly relevant to the specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rootulp @adlerjohn @liamsi @MSevey @rach-id @evan-forbes