feat: add param for gas per message byte #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 29.74% 27.08% -2.67%
==========================================
Files 72 81 +9
Lines 8199 9067 +868
==========================================
+ Hits 2439 2456 +17
- Misses 5531 6375 +844
- Partials 229 236 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I guess this PR depends on this one #893, right? |
|
I know we'll merge #893 soon, but converting to a draft until then as this PR has many duplicate changes and shouldn't be reviewed or merged until its predecessor is |
rahulghangas
force-pushed
the
feat/app-payment-gas-param
branch
from
f344603
to
6059435
Compare
rach-id
previously approved these changes
Nov 10, 2022
evan-forbes
reviewed
Nov 10, 2022
|
Change for removing const and using param in followup PR that addresses #1001 |
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Adds `gasPerMsgByte` as params to the payment module. Defines relevant stores and queries Relevant changes in `proto/payment/*` `x/payment/keeper*` `x/payment/types/*` - [x] finished 1st part of celestiaorg#949 Note: To be merged after celestiaorg#893 and constants for default values can be defined in a cumulative PR
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Adds `gasPerMsgByte` as params to the payment module. Defines relevant stores and queries Relevant changes in `proto/payment/*` `x/payment/keeper*` `x/payment/types/*` - [x] finished 1st part of celestiaorg#949 Note: To be merged after celestiaorg#893 and constants for default values can be defined in a cumulative PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
gasPerMsgByteas params to the payment module.Defines relevant stores and queries
Relevant changes in
proto/payment/*x/payment/keeper*x/payment/types/*GasPerMsgByteas a parameter to payment module #949Note: To be merged after #893 and constants for default values can be defined in a cumulative PR