fix: test packages and coverage generation

[rahulghangas]

• Closes Fix test coverage script #924

[codecov-commenter]

Codecov Report

Merging #966 (d68780d) into main (8204e41) will increase coverage by 24.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #966       +/-   ##
===========================================
+ Coverage   27.08%   51.09%   +24.00%     
===========================================
  Files          81       71       -10     
  Lines        9067     4378     -4689     
===========================================
- Hits         2456     2237      -219     
+ Misses       6375     1915     -4460     
+ Partials      236      226       -10     

Impacted Files	Coverage Δ
x/blob/types/tx.pb.go
x/qgb/types/query.pb.go
x/qgb/types/genesis.pb.go
x/blob/types/tx.pb.gw.go
x/qgb/types/query.pb.gw.go
x/qgb/types/types.pb.go
x/blob/types/params.pb.go
x/blob/types/query.pb.go
x/blob/types/query.pb.gw.go
x/blob/types/genesis.pb.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[rootulp]

[blocking][question] sorry for the naive question but how do we know that code coverage is fixed with this PR? Is there a PR on your fork that demonstrates what the comment for coverage looks like after this PR is merged?

#966 (comment) doesn't appear exhaustive of all packages in this repo.

[rach-id]

Thanks a lot for taking care of this 👍 👍
I left a blocking comment, but since I am not very familiar with uploading test coverage, I might be wrong :D

[rahulghangas]

@rootulp https://app.codecov.io/github/celestiaorg/celestia-app/tree/chore%2Ffix-coverage

#966 (comment) was generated by the buggy script, was resolved in a later commit

[rootulp]

[blocking]
Code coverage on main: https://app.codecov.io/github/celestiaorg/celestia-app/tree/main/ has 8199 lines covered
Code coverage on this branch: https://app.codecov.io/github/celestiaorg/celestia-app/tree/chore%2Ffix-coverage/ has 4845 lines covered

Why does this branch have fewer lines covered? Can it be rebased on top of current main to see what the difference is? If this PR fixes the issue, I would expect more lines to be covered, not less.

[rootulp]

it's not clear to me what the fix is. Can you please elaborate in the PR description or a code comment?

[rach-id]

@rootulp If I understand right:

Code coverage on main: https://app.codecov.io/github/celestiaorg/celestia-app/tree/main/ has 8199 lines covered
Code coverage on this branch: https://app.codecov.io/github/celestiaorg/celestia-app/tree/chore%2Ffix-coverage/ has 4845 lines covered

Probably, because the proto generated files are not included.

[rootulp]

Probably, because the proto generated files are not included.

https://github.com/celestiaorg/celestia-app/pull/966/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R153-R155 removed

          excludelist+=" $(find ./ -type f -name '*.pb.gw.go')"

from the exclude list so I'd expect more proto files to be included in the coverage.txt

[rach-id]

@rootulp I guess it's these files that are excluded:

          excludelist="$(find . -type f -name '*.go' | xargs grep -l 'DONTCOVER')\n"
          excludelist+="$(find . -type f -name '*.pb.*')\n"
          excludelist+="$(find . -type f -path './tests/mocks/*.go')"

As per:

            sed -i.bak "/$(echo $filename | sed 's/\//\\\//g')/d" coverage.txt

Or, I am missing something

[rootulp]

It looks like before and after this PR, .pb.go files are being covered:

• main: https://app.codecov.io/github/celestiaorg/celestia-app/tree/main/?search=.pb.go
• this branch: https://app.codecov.io/github/celestiaorg/celestia-app/tree/chore%2Ffix-coverage/?search=.pb.go&displayType=list

Fewer .pb.go files show up for this branch but I don't think any are intended.

No .pb.gw.go files are being covered in this branch (which seems desirable):

• main: https://app.codecov.io/github/celestiaorg/celestia-app/tree/main/?search=.pb.gw.go
• this branch: https://app.codecov.io/github/celestiaorg/celestia-app/tree/chore%2Ffix-coverage/?search=.pb.gw.go&displayType=list

[rahulghangas]

I don't get why it's picking up those files, or why changing it would help since the command above returns all the *pb.go files successfully when I run it locally

[evan-forbes]

LGTM utACK

thx for this @rahulghangas !

[rahulghangas]

How do I go about triggering a code coverage report generation?

[rach-id]

If I understand right, codecov will automatically push a comment if there were some changes, for the first time the PR is open. Then, it will start updating the comment, it posted the first time, every time a commit does a change to the patterns:

            **/**.go
            go.mod
            go.sum

However, we can always access the coverage from here: https://app.codecov.io/github/celestiaorg/celestia-app/tree/chore%2Ffix-coverage/

To trigger a new coverage report, changes need to be done to the above files. Probably, a dummy commit and revert would do the job. Or, someone with admin access (don't know which permissions they need to have).

[rahulghangas]

https://app.codecov.io/github/celestiaorg/celestia-app/tree/chore%2Ffix-coverage/
All proto files are excluded correctly now

ps - I hate bash!

[rach-id]

@rahulghangas Thanks a lot for handling this 👍 👍 🎉 🎉