Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: rename PFD -> PFB #978

Merged
merged 4 commits into from
Nov 10, 2022
Merged

chore!: rename PFD -> PFB #978

merged 4 commits into from
Nov 10, 2022

Conversation

evan-forbes
Copy link
Member

closes #962

@evan-forbes
Copy link
Member Author

blocked by #972

@evan-forbes evan-forbes changed the base branch from main to evan/BLOB November 8, 2022 15:08
@evan-forbes evan-forbes self-assigned this Nov 8, 2022
@evan-forbes evan-forbes added C: Celestia app chore optional label for items that follow the `chore` conventional commit consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules labels Nov 8, 2022
@evan-forbes evan-forbes added this to the Q4 2022 milestone Nov 8, 2022
rootulp
rootulp previously approved these changes Nov 8, 2022
View reviewed changes
docs/architecture/adr-008-square-size-independent-message-commitments.md Show resolved Hide resolved
proto/blob/tx.proto Show resolved Hide resolved
@evan-forbes evan-forbes mentioned this pull request Nov 10, 2022
Closed
Base automatically changed from evan/BLOB to main November 10, 2022 01:04
@evan-forbes evan-forbes marked this pull request as ready for review November 10, 2022 01:12
@codecov-commenter
Copy link

Codecov Report

Merging #978 (adfc965) into main (22d366f) will not change coverage.
The diff coverage is 46.98%.

@@           Coverage Diff           @@
##             main     #978   +/-   ##
=======================================
  Coverage   29.74%   29.74%           
=======================================
  Files          72       72           
  Lines        8199     8199           
=======================================
  Hits         2439     2439           
  Misses       5531     5531           
  Partials      229      229
Impacted Files Coverage Δ
app/app.go 6.49% <0.00%> (ø)
app/prepare_proposal.go 0.00% <0.00%> (ø)
app/process_proposal.go 0.00% <0.00%> (ø)
x/blob/keeper/msg_server.go 0.00% <ø> (ø)
x/blob/types/events.go 0.00% <0.00%> (ø)
x/blob/types/genesis.go 100.00% <ø> (ø)
x/blob/types/keys.go 0.00% <ø> (ø)
x/blob/types/square_sizes.go 100.00% <ø> (ø)
x/blob/types/tx.pb.gw.go 0.00% <0.00%> (ø)
x/qgb/keeper/keeper.go 57.69% <ø> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rootulp
rootulp previously approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All proposal "message" -> "blob" renames are optional. We may need a search and replace for "message" -> "blob" after this PR anyway but I don't think such a replace needs to be bundled into this PR.

docs/architecture/adr-001-abci++-adoption.md Outdated Show resolved Hide resolved
docs/architecture/adr-001-abci++-adoption.md Outdated Show resolved Hide resolved
docs/architecture/adr-001-abci++-adoption.md Outdated Show resolved Hide resolved
docs/architecture/adr-001-abci++-adoption.md Outdated Show resolved Hide resolved
x/blob/client/cli/wirepayfordata.go Outdated Show resolved Hide resolved
@evan-forbes @rootulp
chore: update a more instances of message -> blob
9373eb1 
Co-authored-by: Rootul P <rootulp@gmail.com>
@evan-forbes evan-forbes merged commit 37dbad1 into main Nov 10, 2022
@evan-forbes evan-forbes deleted the evan/PayForBlob branch November 10, 2022 18:04
@rootulp rootulp mentioned this pull request Nov 10, 2022
Closed
3 tasks
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
@evan-forbes @rootulp @rach-id
chore!: rename PFD -> PFB (celestiaorg#978)
2d84e98 
closes celestiaorg#962

Co-authored-by: Rootul P <rootulp@gmail.com>
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
@evan-forbes @rootulp @rach-id
chore!: rename PFD -> PFB (celestiaorg#978)
40a5ca4 
closes celestiaorg#962

Co-authored-by: Rootul P <rootulp@gmail.com>
@rootulp rootulp mentioned this pull request Nov 18, 2022
Merged
5 tasks
This was referenced Jan 13, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@MSevey MSevey Awaiting requested review from MSevey

@rach-id rach-id Awaiting requested review from rach-id

Assignees

@evan-forbes evan-forbes

Labels
chore optional label for items that follow the `chore` conventional commit consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules
Projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming PayForData => PayForBlob
3 participants
@evan-forbes @codecov-commenter @rootulp