feat: Add checks on FillBlock squareSize #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
reviewed
Nov 9, 2022
vidhanarya
force-pushed
the
check-fill-block-square-size
branch
from
7190041
to
b7c3d14
Compare
Codecov Report
@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 26.13% 29.73% +3.60%
==========================================
Files 77 72 -5
Lines 9353 8202 -1151
==========================================
- Hits 2444 2439 -5
+ Misses 6680 5533 -1147
- Partials 229 230 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rach-id
previously approved these changes
Nov 9, 2022
rootulp
reviewed
Nov 9, 2022
vidhanarya
force-pushed
the
check-fill-block-square-size
branch
from
b7c3d14
to
8b1ba35
Compare
vidhanarya
force-pushed
the
check-fill-block-square-size
branch
from
8b1ba35
to
789cf79
Compare
rootulp
approved these changes
Nov 9, 2022
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Add check on `FillBlock` -> `squareSize` arg: - Check squareSize should be > 2 - Check squareSize is a pow of 2 Closes celestiaorg#867
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Add check on `FillBlock` -> `squareSize` arg: - Check squareSize should be > 2 - Check squareSize is a pow of 2 Closes celestiaorg#867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check on
FillBlock->squareSizearg:Closes #867